Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): fix issue with parser returning panic #4223 #4224

Merged
merged 2 commits into from
Sep 17, 2021
Merged

fix(parser): fix issue with parser returning panic #4223 #4224

merged 2 commits into from
Sep 17, 2021

Conversation

cx-joao-reigota
Copy link
Collaborator

Signed-off-by: João Reigota [email protected]

Closes #4223

Proposed Changes

  • fixed bug with yaml parser returning a panic
  • added ansible vault files to unwanted files

I submit this contribution under the Apache-2.0 license.

@cx-joao-reigota
fix(parser): Fixed issue with parser returning panic
9f552db 
added ansible vault files to unwanted files

Signed-off-by: João Reigota <[email protected]>
@cx-joao-reigota cx-joao-reigota added bug Something isn't working go Pull requests that update Go code labels Sep 17, 2021
@cx-joao-reigota cx-joao-reigota requested a review from a team September 17, 2021 13:53
@cx-joao-reigota cx-joao-reigota self-assigned this Sep 17, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Sep 17, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Sep 17, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

@rogeriopeixotocx rogeriopeixotocx changed the title fix(parser): Fixed issue with parser returning panic #4223 fix(parser): fix issue with parser returning panic #4223 Sep 17, 2021
rogeriopeixotocx
rogeriopeixotocx approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 799ebf4 into master Sep 17, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix_yaml_parser_bug branch September 17, 2021 15:27
@cx-joao-reigota cx-joao-reigota mentioned this pull request Sep 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeriopeixotocx rogeriopeixotocx rogeriopeixotocx approved these changes

Assignees

@cx-joao-reigota cx-joao-reigota

Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KICS panics when parsing ansible vault file
3 participants
@cx-joao-reigota @kicsbot @rogeriopeixotocx