Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): elastic search without slow logs FP #4317

Merged
merged 1 commit into from
Sep 29, 2021
Merged

fix(query): elastic search without slow logs FP #4317

merged 1 commit into from
Sep 29, 2021

Conversation

rogeriopeixotocx
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx commented Sep 29, 2021 •
edited
Loading

Closes #4310

Proposed Changes

  • Fixing query FP
  • Adding new negative sample
  • Query refactoring
  • Adding searchLine

I submit this contribution under the Apache-2.0 license.

@kicsbot
Copy link
Contributor

kicsbot commented Sep 29, 2021

Scan submitted to Checkmarx

@rogeriopeixotocx rogeriopeixotocx requested a review from a team September 29, 2021 10:26
@rogeriopeixotocx rogeriopeixotocx self-assigned this Sep 29, 2021
@rogeriopeixotocx rogeriopeixotocx added accuracy Query accuracy (FN and FP) bug Something isn't working cloudformation CloudFormation query query New query feature labels Sep 29, 2021
@rogeriopeixotocx rogeriopeixotocx added this to the Query Accuracy milestone Sep 29, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Sep 29, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

felipe-avelar
felipe-avelar approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 3a28c7b into master Sep 29, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the fix/elastic_search_without_slow_logs branch September 29, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipe-avelar felipe-avelar felipe-avelar approved these changes

Assignees

@rogeriopeixotocx rogeriopeixotocx

Labels
accuracy Query accuracy (FN and FP) bug Something isn't working cloudformation CloudFormation query query New query feature
Projects
None yet
Milestone
Query Accuracy
Development

Successfully merging this pull request may close these issues.

"ElasticSearch Without Slow Logs" Detects Application Logs
3 participants
@rogeriopeixotocx @kicsbot @felipe-avelar