Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): handle regexp compilation errors #4347

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

rogeriopeixotocx
Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx commented Oct 7, 2021

Closes #4348

I submit this contribution under the Apache-2.0 license.

@rogeriopeixotocx rogeriopeixotocx added the bug Something isn't working label Oct 7, 2021
@rogeriopeixotocx rogeriopeixotocx requested a review from a team October 7, 2021 14:54
@rogeriopeixotocx rogeriopeixotocx self-assigned this Oct 7, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Oct 7, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Oct 7, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

Copy link
Collaborator

@cx-joao-reigota cx-joao-reigota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@felipe-avelar felipe-avelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-joao-reigota cx-joao-reigota merged commit b0381d4 into master Oct 8, 2021
@cx-joao-reigota cx-joao-reigota deleted the fix/validate-regexp branch October 8, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Secret Regex (invalid regex) throwing a panic message
4 participants