Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source): fixed KICS panic when reading invalid metadata (#4413) #4465

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

cx-joao-reigota
Copy link
Collaborator

Signed-off-by: João Reigota [email protected]

Closes #4413

Proposed Changes

  • Added function to check for fields that if missing causes KICS to panic (id, platform)

I submit this contribution under the Apache-2.0 license.

@cx-joao-reigota cx-joao-reigota added the bug Something isn't working label Nov 3, 2021
@cx-joao-reigota cx-joao-reigota requested review from cxlucas and a team November 3, 2021 16:50
@cx-joao-reigota cx-joao-reigota self-assigned this Nov 3, 2021
@kicsbot
Copy link
Contributor

kicsbot commented Nov 3, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Nov 3, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

Copy link
Contributor

@cxlucas cxlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 1ad3637 into master Nov 4, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the joaoReigota1/issue4413 branch November 4, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KICS Panic when reading badly formatted metadata
5 participants