-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(query): policies for CloudFormation #4540
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 8 additions & 3 deletions
11
assets/queries/cloudFormation/ecr_repository_is_publicly_accessible/query.rego
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,23 @@ | ||
| package Cx | ||
|
|
||
| import data.generic.common as common_lib | ||
|
|
||
| CxPolicy[result] { | ||
| resource := input.document[i].Resources[name] | ||
| resource.Type == "AWS::ECR::Repository" | ||
| policy := resource.Properties.RepositoryPolicyText | ||
| statement := policy.Statement[_] | ||
| statement.Effect == "Allow" | ||
| st := common_lib.get_statement(common_lib.get_policy(policy)) | ||
| statement := st[_] | ||
|
|
||
| common_lib.is_allow_effect(statement) | ||
| contains(statement.Principal, "*") | ||
|
|
||
| result := { | ||
| "documentId": input.document[i].id, | ||
| "searchKey": sprintf("Resources.%s.Properties.RepositoryPolicyText.Statement.Principal", [name]), | ||
| "searchKey": sprintf("Resources.%s.Properties.RepositoryPolicyText", [name]), | ||
| "issueType": "IncorrectValue", | ||
| "keyExpectedValue": sprintf("Resources.%s.Properties.RepositoryPolicyText.Statement.Principal doesn't contain '*'", [name]), | ||
| "keyActualValue": sprintf("Resources.%s.Properties.RepositoryPolicyText.Statement.Principal contains '*'", [name]), | ||
| "searchLine": common_lib.build_search_line(["Resource", name, "Properties", "RepositoryPolicyTexts"], []), | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 12 additions & 16 deletions
28
assets/queries/cloudFormation/iam_policies_with_full_privileges/query.rego
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,25 @@ | ||
| package Cx | ||
|
|
||
| import data.generic.common as common_lib | ||
|
|
||
| CxPolicy[result] { | ||
| resource := input.document[i].Resources[name] | ||
| resource.Type == "AWS::IAM::Policy" | ||
| checkPolicy(resource.Properties.PolicyDocument.Statement[_]) | ||
|
|
||
| policy := resource.Properties.PolicyDocument | ||
| st := common_lib.get_statement(common_lib.get_policy(policy)) | ||
| statement := st[_] | ||
|
|
||
| common_lib.is_allow_effect(statement) | ||
| common_lib.equalsOrInArray(statement.Resource, "*") | ||
| common_lib.equalsOrInArray(statement.Action, "*") | ||
|
|
||
| result := { | ||
| "documentId": input.document[i].id, | ||
| "searchKey": sprintf("Resources.%s.Properties.PolicyDocument.Statement", [name]), | ||
| "searchKey": sprintf("Resources.%s.Properties.PolicyDocumentt", [name]), | ||
| "issueType": "IncorrectValue", | ||
| "keyExpectedValue": "'Resources.Properties.PolicyDocument.Statement' doesn't contain '*'", | ||
| "keyActualValue": "'Resources.Properties.PolicyDocument.Statement' contains '*'", | ||
| "searchLine": common_lib.build_search_line(["Resource", name, "Properties", "PolicyDocument"], []), | ||
| } | ||
| } | ||
|
|
||
| checkPolicy(pol) { | ||
| pol.Effect == "Allow" | ||
| pol.Resource == "*" | ||
| checkAction(pol.Action) | ||
| } | ||
|
|
||
| checkAction(act) { | ||
| act == "*" | ||
| } | ||
|
|
||
| checkAction(act) { | ||
| act[_] == "*" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 11 additions & 5 deletions
16
...ies/cloudFormation/iam_policy_grants_assumerole_permission_across_all_services/query.rego
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,25 @@ | ||
| package Cx | ||
|
|
||
| import data.generic.common as common_lib | ||
|
|
||
| CxPolicy[result] { | ||
| resource := input.document[i].Resources[name] | ||
| resource.Type == "AWS::IAM::Policy" | ||
| statements := resource.Properties.PolicyDocument.Statement | ||
|
|
||
| contains(statements[_].Action[_], "sts:AssumeRole") | ||
|
|
||
| policy := resource.Properties.PolicyDocument | ||
| st := common_lib.get_statement(common_lib.get_policy(policy)) | ||
| statement := st[_] | ||
|
|
||
| contains(statements[_].Resource, "*") | ||
| common_lib.is_allow_effect(statement) | ||
| common_lib.equalsOrInArray(statement.Resource, "*") | ||
| common_lib.equalsOrInArray(statement.Action, lower("sts:AssumeRole")) | ||
|
|
||
| result := { | ||
| "documentId": input.document[i].id, | ||
| "searchKey": sprintf("Resources.%s.Properties.PolicyDocument.Statement", [name]), | ||
| "searchKey": sprintf("Resources.%s.Properties.PolicyDocument", [name]), | ||
| "issueType": "IncorrectValue", | ||
| "keyExpectedValue": sprintf("'Resources.%s.Properties.PolicyDocument.Statement' with AssumeRole action does not grant access in all services ('*')", [name]), | ||
| "keyActualValue": sprintf("'Resources.%s.Properties.PolicyDocument.Statement' with AssumeRole action is granting access in all services ('*')", [name]), | ||
| "searchLine": common_lib.build_search_line(["Resource", name, "Properties", "PolicyDocument"], []), | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 13 additions & 19 deletions
32
assets/queries/cloudFormation/iam_policy_grants_full_permissions/query.rego
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,25 @@ | ||
| package Cx | ||
|
|
||
| import data.generic.common as common_lib | ||
|
|
||
| CxPolicy[result] { | ||
| resource := input.document[i].Resources[name] | ||
| resource.Type == "AWS::IAM::Policy" | ||
|
|
||
| statements := resource.Properties.PolicyDocument.Statement | ||
| checkPolicy(statements[s]) | ||
| policy := resource.Properties.PolicyDocument | ||
| st := common_lib.get_statement(common_lib.get_policy(policy)) | ||
| statement := st[_] | ||
|
|
||
| common_lib.is_allow_effect(statement) | ||
| not common_lib.equalsOrInArray(statement.Resource, lower("arn:aws:iam::aws:policy/AdministratorAccess")) | ||
| common_lib.equalsOrInArray(statement.Action, "*") | ||
|
|
||
| result := { | ||
| "documentId": input.document[i].id, | ||
| "searchKey": sprintf("Resources.%s.Properties.PolicyDocument.Statement.Resource=%s", [name, statements[s].Resource]), | ||
| "searchKey": sprintf("Resources.%s.Properties.PolicyDocument", [name]), | ||
| "issueType": "IncorrectValue", | ||
| "keyExpectedValue": sprintf("'Resources.%s.Properties.PolicyDocument.Statement.Resource=%s' does not have full permissions or is Admin", [name, statements[s].Resource]), | ||
| "keyActualValue": sprintf("'Resources.%s.Properties.PolicyDocument.Statement.Resource=%s' has full permissions and is not Admin.", [name, statements[s].Resource]), | ||
| "keyExpectedValue": sprintf("'Resources.%s.Properties.PolicyDocument.Statement.Resource' does not have full permissions or is Admin", [name]), | ||
| "keyActualValue": sprintf("'Resources.%s.Properties.PolicyDocument.Statement.Resource' has full permissions and is not Admin.", [name]), | ||
| "searchLine": common_lib.build_search_line(["Resource", name, "Properties", "PolicyDocument"], []), | ||
| } | ||
| } | ||
|
|
||
| checkPolicy(pol) { | ||
| pol.Effect == "Allow" | ||
| pol.Resource != "arn:aws:iam::aws:policy/AdministratorAccess" | ||
| checkAction(pol.Action) | ||
| } | ||
|
|
||
| checkAction(act) { | ||
| act == "*" | ||
| } | ||
|
|
||
| checkAction(act) { | ||
| act[_] == "*" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 11 additions & 24 deletions
35
assets/queries/cloudFormation/iam_role_allows_all_principals_to_assume/query.rego
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,26 @@ | ||
| package Cx | ||
|
|
||
| import data.generic.common as commonLib | ||
| import data.generic.common as common_lib | ||
|
|
||
| CxPolicy[result] { | ||
| resource := input.document[i].Resources[Name] | ||
| resource := input.document[i].Resources[name] | ||
| resource.Type == "AWS::IAM::Role" | ||
|
|
||
| out := commonLib.json_unmarshal(resource.Properties.AssumeRolePolicyDocument) | ||
| aws := out.Statement[_].Principal.AWS | ||
| policy := resource.Properties.AssumeRolePolicyDocument | ||
| st := common_lib.get_statement(common_lib.get_policy(policy)) | ||
| statement := st[_] | ||
|
|
||
| commonLib.allowsAllPrincipalsToAssume(aws, out.Statement[_]) | ||
|
|
||
| result := { | ||
| "documentId": input.document[i].id, | ||
| "searchKey": sprintf("Resources.%s.Properties.AssumeRolePolicyDocument.Statement.Principal.AWS", [Name]), | ||
| "issueType": "IncorrectValue", | ||
| "keyExpectedValue": sprintf("Resources.%s.Properties.AssumeRolePolicyDocument.Statement.Principal.AWS does not contain ':root'", [Name]), | ||
| "keyActualValue": sprintf("Resources.%s.Properties.AssumeRolePolicyDocument.Statement.Principal.AWS contains ':root'", [Name]), | ||
| } | ||
| } | ||
|
|
||
| CxPolicy[result] { | ||
| resource := input.document[i].Resources[Name] | ||
| resource.Type == "AWS::IAM::Role" | ||
|
|
||
| statement := resource.Properties.AssumeRolePolicyDocument.Statement[_] | ||
| common_lib.is_allow_effect(statement) | ||
| aws := statement.Principal.AWS | ||
|
|
||
| commonLib.allowsAllPrincipalsToAssume(aws, statement) | ||
| common_lib.allowsAllPrincipalsToAssume(aws, statement) | ||
|
|
||
| result := { | ||
| "documentId": input.document[i].id, | ||
| "searchKey": sprintf("Resources.%s.Properties.AssumeRolePolicyDocument.Statement.Principal.AWS", [Name]), | ||
| "searchKey": sprintf("Resources.%s.Properties.AssumeRolePolicyDocument", [name]), | ||
| "issueType": "IncorrectValue", | ||
| "keyExpectedValue": sprintf("Resources.%s.Properties.AssumeRolePolicyDocument.Statement.Principal.AWS does not contain ':root'", [Name]), | ||
| "keyActualValue": sprintf("Resources.%s.Properties.AssumeRolePolicyDocument.Statement.Principal.AWS contains ':root'", [Name]), | ||
| "keyExpectedValue": sprintf("Resources.%s.Properties.AssumeRolePolicyDocument.Statement.Principal.AWS does not contain ':root'", [name]), | ||
| "keyActualValue": sprintf("Resources.%s.Properties.AssumeRolePolicyDocument.Statement.Principal.AWS contains ':root'", [name]), | ||
| "searchLine": common_lib.build_search_line(["Resource", name, "Properties", "AssumeRolePolicyDocument"], []), | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 13 additions & 6 deletions
19
assets/queries/cloudFormation/iot_policy_allows_action_as_wildcard/query.rego
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,24 @@ | ||
| package Cx | ||
|
|
||
| import data.generic.common as common_lib | ||
|
|
||
| CxPolicy[result] { | ||
| resources := input.document[i].Resources[name] | ||
| resources.Type == "AWS::IoT::Policy" | ||
| document := resources.Properties.PolicyDocument | ||
| statements = document.Statement | ||
| statements[k].Action == "*" | ||
|
|
||
| policy := resources.Properties.PolicyDocument | ||
| st := common_lib.get_statement(common_lib.get_policy(policy)) | ||
| statement := st[_] | ||
|
|
||
| common_lib.is_allow_effect(statement) | ||
| common_lib.equalsOrInArray(statement.Action, "*") | ||
|
|
||
| result := { | ||
| "documentId": input.document[i].id, | ||
| "searchKey": sprintf("Resources.%s.Properties.PolicyDocument.Statement.Effect=%s.Action", [name, statements[k].Effect]), | ||
| "searchKey": sprintf("Resources.%s.Properties.PolicyDocument", [name]), | ||
| "issueType": "IncorrectValue", | ||
| "keyExpectedValue": sprintf("Resources.%s.Properties.PolicyDocument.Statement[%s].Action is not '*'", [name, statements[k].Effect]), | ||
| "keyActualValue": sprintf("Resources.%s.Properties.PolicyDocument.Statement[%s].Action is '*'", [name, statements[k].Effect]), | ||
| "keyExpectedValue": sprintf("Resources.%s.Properties.PolicyDocument.Statement.Action is not '*'", [name]), | ||
| "keyActualValue": sprintf("Resources.%s.Properties.PolicyDocument.Statement.Action is '*'", [name]), | ||
| "searchLine": common_lib.build_search_line(["Resource", name, "Properties", "PolicyDocument"], []), | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.