Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraformer): added terraformer integration #4686

Merged
merged 9 commits into from
Jan 19, 2022

Conversation

cx-joao-reigota
Copy link
Collaborator

Proposed Changes

  • added terraformer integration with kics

I submit this contribution under the Apache-2.0 license.

@cx-joao-reigota cx-joao-reigota added feature New feature CI PR related with GitHub Actions CI process go Pull requests that update Go code labels Jan 14, 2022
@cx-joao-reigota cx-joao-reigota added this to the Core Engineering milestone Jan 14, 2022
@cx-joao-reigota cx-joao-reigota self-assigned this Jan 14, 2022
@kicsbot
Copy link
Contributor

kicsbot commented Jan 14, 2022

Scan submitted to Checkmarx

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2022

kics-logo

KICS version: v1.4.8

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 53
Queries failed to execute placeholder 0
Execution time placeholder 1

@kicsbot
Copy link
Contributor

kicsbot commented Jan 14, 2022

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 4 vulnerabilities
High 0 High
Medium 0 Medium
Low 4 Low
Info 0 Info

Violation Summary

No policy violation found

@cx-joao-reigota cx-joao-reigota force-pushed the terraformer_poc branch 2 times, most recently from 4464fac to 5ae6604 Compare January 14, 2022 18:35
@cx-joao-reigota cx-joao-reigota marked this pull request as ready for review January 18, 2022 13:15
@cx-joao-reigota cx-joao-reigota force-pushed the terraformer_poc branch 4 times, most recently from 8640e46 to 1a37612 Compare January 18, 2022 15:55
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀 🚀
Only a minor suggestion:

Signed-off-by: João Reigota <[email protected]>
@kicsbot
Copy link
Contributor

kicsbot commented Jan 18, 2022

Scan not submitted to Checkmarx due to existing Active scan for the same project.

@cx-joao-reigota cx-joao-reigota force-pushed the terraformer_poc branch 2 times, most recently from 7f6d622 to 64313d1 Compare January 19, 2022 07:45
Copy link
Collaborator

@nunoocx nunoocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-joao-reigota cx-joao-reigota merged commit b9f2fba into master Jan 19, 2022
@cx-joao-reigota cx-joao-reigota deleted the terraformer_poc branch January 19, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI PR related with GitHub Actions CI process feature New feature go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants