Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(analyzer): Docker Compose support #4851

Merged
merged 15 commits into from
Mar 21, 2022
Merged

feat(analyzer): Docker Compose support #4851

merged 15 commits into from
Mar 21, 2022

Conversation

joaorufi
Copy link
Contributor

@joaorufi joaorufi commented Feb 16, 2022 •
edited
Loading

Proposed Changes

  • Docker Compose support
  • Generic Contains function to utils package
  • Simplified code on parser Build function

I submit this contribution under the Apache-2.0 license.

@joaorufi joaorufi added feature request Community: new feature request go Pull requests that update Go code labels Feb 16, 2022
@joaorufi joaorufi self-assigned this Feb 16, 2022
@kicsbot
Copy link
Contributor

kicsbot commented Feb 16, 2022

Scan submitted to Checkmarx

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2022 •
edited
Loading

kics-logo

KICS version: v1.5.2

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 52
Queries failed to execute placeholder 0
Execution time placeholder 1

@kicsbot
Copy link
Contributor

kicsbot commented Feb 16, 2022

Scan not submitted to Checkmarx due to existing Active scan for the same project.

@kicsbot
Copy link
Contributor

kicsbot commented Feb 16, 2022

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 5 vulnerabilities
High 0 High
Medium 0 Medium
Low 5 Low
Info 0 Info

Violation Summary

No policy violation found

@joaorufi
fix lint errors
c8bc2d6 
Signed-off-by: joaorufi <[email protected]>
@joaorufi joaorufi marked this pull request as draft February 17, 2022 18:32
@joaorufi joaorufi marked this pull request as ready for review February 18, 2022 19:12
rafaela-soares
rafaela-soares suggested changes Feb 25, 2022
View reviewed changes
@joaorufi
requested changes
20062b1 
Signed-off-by: joaorufi <[email protected]>
@joaorufi
fix text
6a43f17 
Signed-off-by: joaorufi <[email protected]>
@joaorufi joaorufi linked an issue Mar 3, 2022 that may be closed by this pull request
Add/Update Docker queries to support docker-compose.yml #1981
Closed
rafaela-soares
rafaela-soares approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rafaela-soares rafaela-soares merged commit ad91432 into master Mar 21, 2022
@rafaela-soares rafaela-soares deleted the feature/docker-compose-support branch March 21, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaela-soares rafaela-soares rafaela-soares approved these changes

Assignees

@joaorufi joaorufi

Labels
feature request Community: new feature request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add/Update Docker queries to support docker-compose.yml
3 participants
@joaorufi @kicsbot @rafaela-soares