Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): Define NET_BIND_SERVICE as exception in containers_with_added_capabilities k8s rule #4888

Conversation

Churro
Copy link
Contributor

@Churro Churro commented Feb 27, 2022

Proposed Changes

  • Allow NET_BIND_SERVICE as a capability that may be added
    • This is necessary, e.g., to the run nginx ingress controller pods on port 80 and 443 as non-root users, see here
    • It is also inline with the "Restricted policy" implemented in the upcoming Pod Security Admission Controller, see here

I submit this contribution under the Apache-2.0 license.

@kicsbot
Copy link
Contributor

kicsbot commented Feb 27, 2022

Scan submitted to Checkmarx

@rafaela-soares rafaela-soares added query New query feature community Community contribution labels Mar 15, 2022
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thank you so much for the amazing observation and contribution, @Churro! We are very grateful!

@cx-joao-reigota cx-joao-reigota merged commit 424c14f into Checkmarx:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants