fix(query): Fix path to spec in root_container_not_mounted_as_read_only k8s rule #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scan submitted to Checkmarx |
rafaela-soares
suggested changes
Mar 9, 2022
There was a problem hiding this comment.
Hi, @Churro! Thank you so much for another great contribution!
I only have one request:
assets/queries/k8s/root_container_not_mounted_as_read_only/metadata.json
Show resolved
Hide resolved
|
Cx-SAST SummaryTotal of 5 vulnerabilities Violation SummaryNo policy violation found |
cx-joao-reigota
requested changes
Mar 15, 2022
There was a problem hiding this comment.
Hi @Churro, everything looks good to me, the only thing I would like to request here is the use of the searchLine
Thank you for your great contributions
|
Hi @joaoReigota1, thank you for the review. As requested, I've now added the |
cx-joao-reigota
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
container.securityContextwith the check forreadOnlyRootFilesystemsearchKeyto the actual pathI submit this contribution under the Apache-2.0 license.