Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(query): S3 Bucket Policy Accepts Http Requests #4949

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Fix(query): S3 Bucket Policy Accepts Http Requests #4949

merged 2 commits into from
Mar 9, 2022

Conversation

cxAndreFelicidade
Copy link
Contributor

Proposed Changes

  • Added Allow true to deny_http_requests function

I submit this contribution under the Apache-2.0 license.

@cxAndreFelicidade cxAndreFelicidade added query New query feature aws PR related with AWS Cloud labels Mar 9, 2022
@cxAndreFelicidade cxAndreFelicidade added this to the Query Accuracy milestone Mar 9, 2022
@cxAndreFelicidade cxAndreFelicidade self-assigned this Mar 9, 2022
@kicsbot
Copy link
Contributor

kicsbot commented Mar 9, 2022

Scan submitted to Checkmarx

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

kics-logo

KICS version: v1.5.2

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 52
Queries failed to execute placeholder 0
Execution time placeholder 1

@kicsbot
Copy link
Contributor

kicsbot commented Mar 9, 2022

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 5 vulnerabilities
High 0 High
Medium 0 Medium
Low 5 Low
Info 0 Info

Violation Summary

No policy violation found

rafaela-soares
rafaela-soares approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rafaela-soares rafaela-soares merged commit 1e1654f into master Mar 9, 2022
@rafaela-soares rafaela-soares deleted the query/s3_bucket_policy_accepts_http_requests branch March 9, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaela-soares rafaela-soares rafaela-soares approved these changes

@cx-joao-reigota cx-joao-reigota Awaiting requested review from cx-joao-reigota

@joaorufi joaorufi Awaiting requested review from joaorufi

Assignees

@cxAndreFelicidade cxAndreFelicidade

Labels
aws PR related with AWS Cloud query New query feature
Projects
None yet
Milestone
Query Accuracy
Development

Successfully merging this pull request may close these issues.
3 participants
@cxAndreFelicidade @kicsbot @rafaela-soares