Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): add a missing SSE way for SQS #4984

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions assets/queries/terraform/aws/sqs_with_sse_disabled/query.rego
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,42 @@ package Cx

import data.generic.common as common_lib

## two ways to activated SSE : kms_master_key_id OR sqs_managed_sse_enabled
## https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sqs_queue#server-side-encryption-sse
sse_activated(obj) {
common_lib.valid_key(obj, "kms_master_key_id")
} else {
common_lib.valid_key(obj, "sqs_managed_sse_enabled")
} else = false {
true
}

CxPolicy[result] {
resource := input.document[i].resource.aws_sqs_queue[name]
not common_lib.valid_key(resource, "kms_master_key_id")

resource.sqs_managed_sse_enabled == false

result := {
"documentId": input.document[i].id,
"searchKey": sprintf("aws_sqs_queue[%s].sqs_managed_sse_enabled", [name]),
"issueType": "IncorrectValue",
"keyExpectedValue": sprintf("aws_sqs_queue[%s].sqs_managed_sse_enabled must be set to true", [name]),
"keyActualValue": sprintf("aws_sqs_queue[%s].sqs_managed_sse_enabled is set to false", [name]),
"searchLine": common_lib.build_search_line(["resource", "aws_sqs_queue", name, "sqs_managed_sse_enabled"], []),
}
}

CxPolicy[result] {
resource := input.document[i].resource.aws_sqs_queue[name]
sse_activated(resource) == false

result := {
"documentId": input.document[i].id,
"searchKey": sprintf("aws_sqs_queue[%s]", [name]),
"issueType": "MissingAttribute",
"keyExpectedValue": "aws_sqs_queue.kms_master_key_id is defined and not null",
"keyActualValue": "aws_sqs_queue.kms_master_key_id is undefined or null",
"keyExpectedValue": sprintf("aws_sqs_queue[%s].kms_master_key_id or aws_sqs_queue[%s].sqs_managed_sse_enabled are defined and not null", [name, name]),
"keyActualValue": sprintf("aws_sqs_queue[%s].kms_master_key_id and aws_sqs_queue[%s].sqs_managed_sse_enabled are undefined or null", [name, name]),
"searchLine": common_lib.build_search_line(["resource", "aws_sqs_queue", name], []),
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
resource "aws_sqs_queue" "negative3" {
name = "terraform-example-queue"
sqs_managed_sse_enabled = true
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
resource "aws_sqs_queue" "positive7" {
name = "terraform-example-queue"
sqs_managed_sse_enabled = false
}
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,11 @@
"severity": "HIGH",
"line": 1,
"fileName": "positive6.tf"
},
{
"queryName": "SQS With SSE Disabled",
"severity": "HIGH",
"line": 3,
"fileName": "positive7.tf"
}
]