Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): Added kubelet config to Authorization Mode Set To Always Allow query #5017

Merged
merged 7 commits into from
Mar 21, 2022
Merged

fix(query): Added kubelet config to Authorization Mode Set To Always Allow query #5017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a789338
...
joaorufi Mar 18, 2022
6f8fc70
Merge branch 'master' into fix-query/kubelet-config-authorization-mode
joaorufi Mar 18, 2022
1b8fa87
kubelet config file
joaorufi Mar 18, 2022
60dfae0
fix tests
joaorufi Mar 18, 2022
a74b214
added model json to tests
joaorufi Mar 18, 2022
f594d58
Merge branch 'master' into fix-query/kubelet-config-authorization-mode
joaorufi Mar 21, 2022
79e2f8e
kubelet validation
joaorufi Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/validate-k8s-samples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ name: validate-k8s-samples
on:
pull_request:
paths:
- "assets/queries/k8s/**/test/*.yaml"
- "assets/queries/k8s/**/test/*.yml"
- "assets/queries/k8s/**/test/*.yaml"
- "assets/queries/k8s/**/test/*.yml"

jobs:
validate-k8s-manifests:
Expand All @@ -28,6 +28,6 @@ jobs:
run: |
python3 -u .github/scripts/samples-linters/validate-syntax.py \
"assets/queries/k8s/**/test/*.yaml" \
--extra ' --skip-kinds CustomResourceDefinition' \
--extra ' --skip-kinds CustomResourceDefinition,KubeletConfiguration' \
--linter .bin/kubeval \
--skip '.github/scripts/samples-linters/ignore-list/k8s' -v
15 changes: 15 additions & 0 deletions assets/queries/k8s/authorization_mode_set_to_always_allow/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,21 @@ CxPolicy[result] {
}
}

CxPolicy[result] {
resource := input.document[i]
resource.kind == "KubeletConfiguration"

resource.authorization.mode == "AlwaysAllow"

result := {
"documentId": input.document[i].id,
"searchKey": "kind={{KubeletConfiguration}}.authorization.mode",
"issueType": "IncorrectValue",
"keyExpectedValue": "authorization.mode attribute should not be 'AlwaysAllow'",
"keyActualValue": "authorization.mode attribute is equal to 'AlwaysAllow'",
}
}

hasFlagWithValue(container, flag, value) {
command := container.command
startswith(command[a], flag)
Expand Down
11 changes: 11 additions & 0 deletions assets/queries/k8s/authorization_mode_set_to_always_allow/test/negative5.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
apiVersion: kubelet.config.k8s.io/v1beta1
kind: KubeletConfiguration
address: "192.168.0.8"
port: 20250
serializeImagePulls: false
readOnlyPort: 0
authentication:
anonymous:
enabled: false
authorization:
mode: webhook
8 changes: 8 additions & 0 deletions assets/queries/k8s/authorization_mode_set_to_always_allow/test/negative6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"kind": "KubeletConfiguration",
"apiVersion": "kubelet.config.k8s.io/v1beta1",
"address": "0.0.0.0",
"authorization": {
"mode": "webhook"
}
}
11 changes: 11 additions & 0 deletions assets/queries/k8s/authorization_mode_set_to_always_allow/test/positive5.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
apiVersion: kubelet.config.k8s.io/v1beta1
kind: KubeletConfiguration
address: "192.168.0.8"
port: 20250
serializeImagePulls: false
readOnlyPort: 0
authentication:
anonymous:
enabled: false
authorization:
mode: AlwaysAllow
8 changes: 8 additions & 0 deletions assets/queries/k8s/authorization_mode_set_to_always_allow/test/positive6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"kind": "KubeletConfiguration",
"apiVersion": "kubelet.config.k8s.io/v1beta1",
"address": "0.0.0.0",
"authorization": {
"mode": "AlwaysAllow"
}
}
12 changes: 12 additions & 0 deletions assets/queries/k8s/authorization_mode_set_to_always_allow/test/positive_expected_result.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,17 @@
"severity": "MEDIUM",
"line": 11,
"filename": "positive4.yaml"
},
{
"queryName": "Authorization Mode Set To Always Allow",
"severity": "MEDIUM",
"line": 11,
"filename": "positive5.yaml"
},
{
"queryName": "Authorization Mode Set To Always Allow",
"severity": "MEDIUM",
"line": 6,
"filename": "positive6.json"
}
]
2 changes: 1 addition & 1 deletion test/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ var (
"../assets/queries/terraform/kubernetes": {FileKind: []model.FileKind{model.KindTerraform, model.KindJSON}, Platform: "terraform"},
"../assets/queries/terraform/general": {FileKind: []model.FileKind{model.KindTerraform, model.KindJSON}, Platform: "terraform"},
"../assets/queries/terraform/alicloud": {FileKind: []model.FileKind{model.KindTerraform, model.KindJSON}, Platform: "terraform"},
"../assets/queries/k8s": {FileKind: []model.FileKind{model.KindYAML}, Platform: "k8s"},
"../assets/queries/k8s": {FileKind: []model.FileKind{model.KindYAML, model.KindJSON}, Platform: "k8s"},
"../assets/queries/cloudFormation/aws": {FileKind: []model.FileKind{model.KindYAML, model.KindJSON}, Platform: "cloudFormation"},
"../assets/queries/cloudFormation/aws_sam": {FileKind: []model.FileKind{model.KindYAML}, Platform: "cloudFormation"},
"../assets/queries/ansible/aws": {FileKind: []model.FileKind{model.KindYAML}, Platform: "ansible"},
Expand Down