Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fixed "S3 Static Website Host Enabled" for CloudFormation #5060

Merged
merged 2 commits into from
Mar 28, 2022
Merged

fix(query): fixed "S3 Static Website Host Enabled" for CloudFormation #5060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f0e380
fixed "S3 Static Website Host Enabled" for CF
rafaela-soares Mar 28, 2022
9c209a1
Merge branch 'master' into fix/s3_static_website_host_enabled
rafaela-soares Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions assets/queries/cloudFormation/aws/s3_static_website_host_enabled/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package Cx

import data.generic.common as common_lib

CxPolicy[result] {
resource := input.document[i].Resources[name]
resource.Type == "AWS::S3::Bucket"
Expand Down Expand Up @@ -37,9 +39,10 @@ checkPublicAccessBlockConfiguration(properties) {
}

checkWebsiteConfiguration(properties) {
properties.WebsiteConfiguration != null
common_lib.valid_key(properties, "WebsiteConfiguration") # ensure that is defined and not null
}

checkWebsiteConfiguration(properties) {
properties.AccessControl != null
common_lib.valid_key(properties, "AccessControl") # ensure that is defined and not null
properties.AccessControl != "Private"
}
3 changes: 2 additions & 1 deletion assets/queries/cloudFormation/aws/s3_static_website_host_enabled/test/negative2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
"BlockPublicPolicy": true,
"IgnorePublicAcls": true,
"RestrictPublicBuckets": true
}
},
"AccessControl": "Private"
}
}
}
Expand Down