Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(query): AWS IAM Policy Grants Full Permissions for Terraform #5064

Merged
merged 3 commits into from
Mar 28, 2022
Merged

update(query): AWS IAM Policy Grants Full Permissions for Terraform #5064

merged 3 commits into from
Mar 28, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva commented Mar 28, 2022 •
edited
Loading

Closes #5058

Proposed Changes

  • Updated resourceType to verify aws_iam_policy instead of aws_iam_policy_attachment

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added query New query feature terraform Terraform query aws PR related with AWS Cloud labels Mar 28, 2022
@cxMiguelSilva cxMiguelSilva added this to the Queries Support milestone Mar 28, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Mar 28, 2022
@kicsbot
Copy link
Contributor

kicsbot commented Mar 28, 2022

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Mar 28, 2022

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 5 vulnerabilities
High 0 High
Medium 0 Medium
Low 5 Low
Info 0 Info

Violation Summary

No policy violation found

rafaela-soares
rafaela-soares approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@cxMiguelSilva cxMiguelSilva mentioned this pull request Mar 28, 2022
Closed
cx-joao-reigota
cx-joao-reigota approved these changes Mar 28, 2022
View reviewed changes
Copy link
Collaborator

@cx-joao-reigota cx-joao-reigota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-joao-reigota cx-joao-reigota merged commit b4a2a10 into master Mar 28, 2022
@cx-joao-reigota cx-joao-reigota deleted the update/iam_policy_grants_full_permissions branch March 28, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaela-soares rafaela-soares rafaela-soares approved these changes

@cx-joao-reigota cx-joao-reigota cx-joao-reigota approved these changes

Assignees

@cxMiguelSilva cxMiguelSilva

Labels
aws PR related with AWS Cloud query New query feature terraform Terraform query
Projects
None yet
Milestone
Queries Support
Development

Successfully merging this pull request may close these issues.

Add/Update \[QUERY_NAME\] query for \[PLATFORM\] (Terraform, Ansible, ..)
4 participants
@cxMiguelSilva @kicsbot @rafaela-soares @cx-joao-reigota