-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete(query): Remove false positive host_aliases_undefined_or_empty k8s rule #5077
Conversation
Scan submitted to Checkmarx |
Hello, @Churro! Your PR has not been forgotten. Thank you so much for being so collaborative 😊 |
Hello again, @Churro! Our security team confirmed that you are right! Thank you so much for noticing and reporting! 🚀 We will be glad to add your contribution to the next release. Can we ask you to also delete the query |
Hi @rafaela-soares, Thank you for following up on this! As requested, I've now also deleted the TF rule. |
Hello again, @Churro! Thank you so much! Sorry for bothering again. Can you please merge the branch with the KICS master? We had a bug in the validate-queries-metadata test. |
Sure, no problem. Seems to work fine now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you much, @Churro! 🚀
Proposed Changes
hostAliases
if no resolver is available. This is no security issue though.hostAliases
would not prevent this (as long asreadOnlyRootFilesystem: false
).hostAliases
definition seems flawed in the first place: usually, you want to use kube-dns and not list combinations of hostname and IP address manually. This is analogous to how we use the Internet generally, nowadays.I submit this contribution under the Apache-2.0 license.