Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): Default Service Account In Use for Kubernetes #5157

Closed
wants to merge 1 commit into from

Conversation

cxMiguelSilva
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva commented Apr 7, 2022

Proposed Changes

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added query New query feature kubernetes Kubernetes query labels Apr 7, 2022
@cxMiguelSilva cxMiguelSilva added this to the Queries Support milestone Apr 7, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Apr 7, 2022
@kicsbot
Copy link
Contributor

kicsbot commented Apr 7, 2022

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Apr 7, 2022

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 5 vulnerabilities
High 0 High
Medium 0 Medium
Low 5 Low
Info 0 Info

Violation Summary

No policy violation found

@Churro
Copy link
Contributor

Churro commented Apr 7, 2022

Hi @cxMiguelSilva, just got tagged by you referencing my PR 😎

Just wanted to let you know that this check is already realized by the service_account_token_automount_not_disabled rule. It additionally covers another case, where automountServiceAccountToken is specified separately.

@cxMiguelSilva
Copy link
Collaborator Author

Hi @cxMiguelSilva, just got tagged by you referencing my PR 😎

Just wanted to let you know that this check is already realized by the service_account_token_automount_not_disabled rule. It additionally covers another case, where automountServiceAccountToken is specified separately.

Hi @Churro thanks a lot for your help 😀

@cxMiguelSilva cxMiguelSilva deleted the query/default_service_account_in_use branch August 18, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kubernetes Kubernetes query query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants