Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(query): Viewer Protocol Policy Allows HTTP #5174

Merged
merged 1 commit into from
Apr 12, 2022
Merged

update(query): Viewer Protocol Policy Allows HTTP #5174

merged 1 commit into from
Apr 12, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva commented Apr 11, 2022 •
edited
Loading

Closes #5156

Proposed Changes

  • update to verify if is defined to allow-all

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added query New query feature cloudformation CloudFormation query aws PR related with AWS Cloud labels Apr 11, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Apr 11, 2022
@kicsbot
Copy link
Contributor

kicsbot commented Apr 11, 2022

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented Apr 11, 2022

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 5 vulnerabilities
High 0 High
Medium 0 Medium
Low 5 Low
Info 0 Info

Violation Summary

No policy violation found

@cxMiguelSilva cxMiguelSilva mentioned this pull request Apr 11, 2022
Closed
rafaela-soares
rafaela-soares approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joaorufi joaorufi merged commit 6fc395f into master Apr 12, 2022
@joaorufi joaorufi deleted the update/viewer_protocol_policy_allows_http branch April 12, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaela-soares rafaela-soares rafaela-soares approved these changes

@joaorufi joaorufi joaorufi approved these changes

Assignees

@cxMiguelSilva cxMiguelSilva

Labels
aws PR related with AWS Cloud cloudformation CloudFormation query query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add/Update Viewer Protocol Policy Allows HTTP query for Cloudformation
4 participants
@cxMiguelSilva @kicsbot @rafaela-soares @joaorufi