-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scan): consider .gitignore to automatically exclude paths by default #5506
Conversation
@rafaela-soares I would suggest having the default behavior as of today, meaning .gitignore content will be taken into consideration as part of the scan, and the newly added flag, which can be called If we do that, we do not break the current usage of the CLI, and we are having a "strict by default" approach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the suggestions
Hello, @roi-orca! Thank you so much for being involved in this question and for your suggestion. It was a product decision to exclude paths specified within .gitignore file by default. A few users suggested that since the .gitignore file presents the files that will be not committed. Since it can be considered a breaking change, this new behavior will be only included from version 1.6. To disable this behavior, you can use flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Issue #4584 will be closed when the branch
release/1.6
is merged into the master.Proposed Changes
.gitignore
to automatically exclude paths by defaultI submit this contribution under the Apache-2.0 license.