fix(keyExpectedValue): convert is not to a recommendation rather than a current status
#5575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liorj-orca
force-pushed
the
fix/keyExpectedValue_is_not
branch
from
79b36f0 to
7670aee
Compare
rafaela-soares
suggested changes
Jul 11, 2022
There was a problem hiding this comment.
Hello again, @liorj-orca!
Thank you so much for your work! It really improves the keyExpectedValue!
I only have minor suggestions, if you do not mind:
assets/queries/ansible/azure/trusted_microsoft_services_not_enabled/query.rego
Outdated
Show resolved
Hide resolved
liorj-orca
force-pushed
the
fix/keyExpectedValue_is_not
branch
from
7670aee to
1504f32
Compare
rafaela-soares
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
I submit this contribution under the Apache-2.0 license.