Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keyExpectedValue): ansible-gcp queries convert to a recommendation rather than a current status #5591

Merged

Conversation

liorj-orca
Copy link
Contributor

Closes #

Proposed Changes

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added the community Community contribution label Jul 13, 2022
@kaplanlior
Copy link
Contributor

We have a few instances of "should differ from 'none' ".
Would "should not be 'none'" be better phrasing?

rafaela-soares
rafaela-soares previously approved these changes Jul 13, 2022
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thank you so much, @liorj-orca!

@liorj-orca liorj-orca force-pushed the fix/keyExpectedValue_ansible_gcp branch from 0cc4b25 to a8f5721 Compare July 13, 2022 12:48
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
TYSM for your contribution @liorj-orca !!

@kaplanlior kaplanlior merged commit b61dbe4 into Checkmarx:master Jul 13, 2022
@rafaela-soares rafaela-soares added the query New query feature label Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants