Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): add check for ALB use in Terraform AWS Security Query #5593

Merged
merged 3 commits into from
Jul 14, 2022
Merged

fix(query): add check for ALB use in Terraform AWS Security Query #5593

merged 3 commits into from
Jul 14, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva commented Jul 13, 2022 •
edited by rafaela-soares
Loading

Closes #5547

Proposed Changes

  • Add check for ALB in Auto Scaling Group With No Associated ELB for Terraform AWS

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added query New query feature terraform Terraform query aws PR related with AWS Cloud labels Jul 13, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Jul 13, 2022
@rafaela-soares rafaela-soares changed the title fix(query): Add check for ALB use in Terraform AWS Security Query fix(query): add check for ALB use in Terraform AWS Security Query Jul 13, 2022
@ghost ghost mentioned this pull request Jul 13, 2022
Closed
rafaela-soares
rafaela-soares approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rafaela-soares rafaela-soares merged commit 55aefaa into master Jul 14, 2022
@rafaela-soares rafaela-soares deleted the fix/auto_scaling_group_with_no_associated_elb branch July 14, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaela-soares rafaela-soares rafaela-soares approved these changes

Assignees

@cxMiguelSilva cxMiguelSilva

Labels
aws PR related with AWS Cloud query New query feature terraform Terraform query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Terraform] AWS Auto Scaling Group With No Associated ELB False Positive
2 participants
@cxMiguelSilva @rafaela-soares