feat(knative&crossplane): add support to knative and crossplane #5634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/BurntSushi/toml](https://github.com/BurntSushi/toml) from 1.1.0 to 1.2.0. - [Release notes](https://github.com/BurntSushi/toml/releases) - [Commits](BurntSushi/toml@v1.1.0...v1.2.0) --- updated-dependencies: - dependency-name: github.com/BurntSushi/toml dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…5628) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.58 to 1.44.59. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.44.58...v1.44.59) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: João Reigota <[email protected]> Co-authored-by: Rafaela Soares <[email protected]>
cxMiguelSilva
added
feature
rafaela-soares
suggested changes
Jul 25, 2022
There was a problem hiding this comment.
A few additional considerations:
-
Maybe it will make sense to use the walk function to reduce the number of policies (at the moment, the query is looking kinda the same for both kinds)
-
Is it metadata.name required in Crossplane?
-
Please, update the branch with the release/1.6
assets/queries/crossplane/aws/cloudfront_logging_disabled/query.rego
Outdated
Show resolved
Hide resolved
assets/queries/crossplane/aws/cloudfront_logging_disabled/query.rego
Outdated
Show resolved
Hide resolved
assets/queries/crossplane/aws/cloudfront_logging_disabled/query.rego
Outdated
Show resolved
Hide resolved
assets/queries/crossplane/gcp/google_container_node_pool_auto_repair_disabled/query.rego
Outdated
Show resolved
Hide resolved
assets/queries/crossplane/gcp/google_container_node_pool_auto_repair_disabled/query.rego
Outdated
Show resolved
Hide resolved
assets/queries/crossplane/gcp/google_container_node_pool_auto_repair_disabled/query.rego
Outdated
Show resolved
Hide resolved
rafaela-soares
suggested changes
Jul 25, 2022
rafaela-soares
suggested changes
Jul 26, 2022
assets/queries/ansible/aws/elb_using_weak_ciphers/metadata.json
Outdated
Show resolved
Hide resolved
rafaela-soares
suggested changes
Jul 28, 2022
assets/queries/crossplane/aws/cloudwatch_without_retention_period_specified/metadata.json
Outdated
Show resolved
Hide resolved
assets/queries/crossplane/aws/cloudwatch_without_retention_period_specified/query.rego
Outdated
Show resolved
Hide resolved
assets/queries/crossplane/aws/cloudwatch_without_retention_period_specified/query.rego
Outdated
Show resolved
Hide resolved
assets/queries/crossplane/aws/db_instance_storage_not_encrypted/metadata.json
Outdated
Show resolved
Hide resolved
assets/queries/crossplane/aws/neptune_database_cluster_encryption_disabled/query.rego
Outdated
Show resolved
Hide resolved
rafaela-soares
suggested changes
Jul 28, 2022
assets/queries/crossplane/aws/cloudwatch_without_retention_period_specified/query.rego
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I submit this contribution under the Apache-2.0 license.