Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bom): change AWS BOM resource_accessibility output values #5639

Merged
merged 5 commits into from
Jul 28, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva commented Jul 27, 2022

Proposed Changes

  • change AWS BOM resource_accessibility output values from hasPolicy to public or hasPolicy once the presence of a policy is detected.

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added aws PR related with AWS Cloud BoM labels Jul 27, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Jul 27, 2022
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rafaela-soares rafaela-soares merged commit fc9a716 into master Jul 28, 2022
@rafaela-soares rafaela-soares deleted the fix/terraform_bom_resource_accessibility branch July 28, 2022 13:11
rafaela-soares added a commit that referenced this pull request Jul 29, 2022
* build(deps): bump github.com/BurntSushi/toml from 1.1.0 to 1.2.0 (#5627)

Bumps [github.com/BurntSushi/toml](https://github.com/BurntSushi/toml) from 1.1.0 to 1.2.0.
- [Release notes](https://github.com/BurntSushi/toml/releases)
- [Commits](BurntSushi/toml@v1.1.0...v1.2.0)

---
updated-dependencies:
- dependency-name: github.com/BurntSushi/toml
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github.com/aws/aws-sdk-go from 1.44.58 to 1.44.59 (#5628)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.58 to 1.44.59.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md)
- [Commits](aws/aws-sdk-go@v1.44.58...v1.44.59)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs(kicsbot): update images digest (#5629)

* fix(detector): fixed memory leak (#5626)

Co-authored-by: João Reigota <[email protected]>
Co-authored-by: Rafaela Soares <[email protected]>

* fix(bom): change AWS BOM resource_accessibility output values (#5639)

* update bom

* udpate cf bom efs

* requested changes

* change aproach

* update accessibility status

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rafaela Soares <[email protected]>
Co-authored-by: João Reigota <[email protected]>
Co-authored-by: Rafaela Soares <[email protected]>
Co-authored-by: Miguel Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws PR related with AWS Cloud BoM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants