Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): add missing name check in S3Bucket for AWS CloudFormation #5642

Merged
merged 11 commits into from
Aug 1, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

Proposed Changes

  • add missing name check in S3Bucket for AWS CloudFormation

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added query New query feature cloudformation CloudFormation query aws PR related with AWS Cloud labels Jul 28, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Jul 28, 2022
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rafaela-soares rafaela-soares merged commit 6dbf299 into master Aug 1, 2022
@rafaela-soares rafaela-soares deleted the fix/cf_miss_name_check_bucket_policy branch August 1, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws PR related with AWS Cloud cloudformation CloudFormation query query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants