-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query): azure aks rbac-variable changed #5652
Conversation
The failing test does not seem to have to do with my changes.. |
Yes, you are right, @rndmh3ro! Do you mind fixing the samples, please? |
Locally there are really much errors (>50) so I'd rather not fix them in this PR. :D |
We can only approve and merge the PR if all the tests passed. I will talk to the team to take a look and solve the |
When running the same python-script which github actions runs, I get far less errors, so I fixed these. :) |
I don't know why the tests fail now. :( |
You will need to do this change, @rndmh3ro : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thank you so much, @rndmh3ro!
Proposed Changes
I submit this contribution under the Apache-2.0 license.