Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker parser): added resolver for args #5696

Merged
merged 3 commits into from
Aug 17, 2022
Merged

fix(docker parser): added resolver for args #5696

merged 3 commits into from
Aug 17, 2022

Conversation

rafaela-soares
Copy link
Contributor

Closes #5621

Proposed Changes

  • added resolver for args

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added bug Something isn't working go Pull requests that update Go code labels Aug 12, 2022
@rafaela-soares rafaela-soares self-assigned this Aug 12, 2022
cxMiguelSilva
cxMiguelSilva approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaela-soares rafaela-soares merged commit a09eaad into master Aug 17, 2022
@rafaela-soares rafaela-soares deleted the fix/resolve_args_in_dockerfile branch August 17, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

@cx-joao-reigota cx-joao-reigota Awaiting requested review from cx-joao-reigota

Assignees

@rafaela-soares rafaela-soares

Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for variables inbase image name
2 participants
@rafaela-soares @cxMiguelSilva