Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): improve RegEx rule in curl_or_wget_instead_of_add #5706

Merged
merged 2 commits into from
Aug 17, 2022
Merged

fix(query): improve RegEx rule in curl_or_wget_instead_of_add #5706

merged 2 commits into from
Aug 17, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

Closes #5699

Proposed Changes

  • improve RegEx to check :// in http/https check inside query

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added query New query feature docker Docker query labels Aug 17, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Aug 17, 2022
rafaela-soares
rafaela-soares suggested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a negative sample. What do you think?

rafaela-soares
rafaela-soares approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rafaela-soares rafaela-soares merged commit c89a217 into master Aug 17, 2022
@rafaela-soares rafaela-soares deleted the fix/curl_or_wget_instead_of_add branch August 17, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaela-soares rafaela-soares rafaela-soares approved these changes

Assignees

@cxMiguelSilva cxMiguelSilva

Labels
docker Docker query query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query "Curl or Wget Instead of Add" wrongly detects some filenames as urls
2 participants
@cxMiguelSilva @rafaela-soares