Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolver): consider comments in YAML resolver #5735

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

rafaela-soares
Copy link
Contributor

Closes #5685

Proposed Changes

  • consider comments in YAML resolver

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added bug Something isn't working go Pull requests that update Go code labels Aug 25, 2022
@rafaela-soares rafaela-soares added this to the Core Engineering milestone Aug 25, 2022
@rafaela-soares rafaela-soares self-assigned this Aug 25, 2022
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@cx-joao-reigota cx-joao-reigota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaela-soares rafaela-soares merged commit 0dc1382 into master Aug 26, 2022
@rafaela-soares rafaela-soares deleted the fix/comments_in_resolved_files branch August 26, 2022 10:20
rafaela-soares added a commit that referenced this pull request Aug 26, 2022
* fix(resolver): consider comments in YAML resolver (#5735)

* add

* fixed #5685

* improving

* docs(kicsbot): update images digest (#5731)

* docs(kicsbot): update github-action image digest (#5734)

Co-authored-by: nunoocx <[email protected]>

Co-authored-by: Rafaela Soares <[email protected]>
Co-authored-by: nunoocx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ansible include causes kics to ignore it's ignore patterns
3 participants