fix(query): fix queries expected value #5970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liorj-orca
force-pushed
the
fix/keyExpectedValue_should_be_set
branch
4 times, most recently
from
e80e2ff to
dae4588
Compare
rafaela-soares
suggested changes
Oct 28, 2022
There was a problem hiding this comment.
Hi @liorj-orca,
We are glad to see you around! Thank you so much for continuing to improve KICS 🚀
I only have minor suggestions:
assets/queries/terraform/gcp/sql_db_instance_is_publicly_accessible/query.rego
Outdated
Show resolved
Hide resolved
liorj-orca
force-pushed
the
fix/keyExpectedValue_should_be_set
branch
from
dae4588 to
cd8203b
Compare
rafaela-soares
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
I submit this contribution under the Apache-2.0 license.