Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bom): added Kinesis support for CloudFormation and Terraform #5983

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

rafaela-soares
Copy link
Contributor

Proposed Changes

  • added Kinesis support for CloudFormation and Terraform

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added cloudformation CloudFormation query terraform Terraform query aws PR related with AWS Cloud BoM labels Nov 3, 2022
@rafaela-soares rafaela-soares self-assigned this Nov 3, 2022
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gitguardian
Copy link

gitguardian bot commented Nov 8, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
4906207 RSA Private Key 042fa12 assets/queries/common/passwords_and_secrets/test/positive42.tf View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@rafaela-soares rafaela-soares merged commit f5acdbf into master Nov 8, 2022
@rafaela-soares rafaela-soares deleted the feat/bom_kinesis branch November 8, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws PR related with AWS Cloud BoM cloudformation CloudFormation query terraform Terraform query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants