Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): improved regex of "Asymmetric private key" #5984

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

rafaela-soares
Copy link
Contributor

Proposed Changes

  • improved regex of "Asymmetric private key"

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added the query New query feature label Nov 4, 2022
@rafaela-soares rafaela-soares self-assigned this Nov 4, 2022
@gitguardian
Copy link

gitguardian bot commented Nov 4, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
4906207 RSA Private Key 53dac14 assets/queries/common/passwords_and_secrets/test/positive42.tf View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link
Contributor

@gabriel-cx gabriel-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaela-soares rafaela-soares merged commit 7f122a3 into master Nov 4, 2022
@rafaela-soares rafaela-soares deleted the fix/asymmetric_private_key branch November 4, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants