Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scanner panics when ctx timeout #5994

Merged
merged 1 commit into from
Nov 18, 2022
Merged

fix: scanner panics when ctx timeout #5994

merged 1 commit into from
Nov 18, 2022

Conversation

joelboim
Copy link
Contributor

Closes #5986

Proposed Changes

  • Return err in QueryLoader.LoadQuery when ctx timeout, instead of nil, to prevent nil dereference panic.

I submit this contribution under the Apache-2.0 license.

@rafaela-soares rafaela-soares added community Community contribution go Pull requests that update Go code labels Nov 11, 2022
rafaela-soares
rafaela-soares approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@rafaela-soares rafaela-soares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thank you so much for contributing to the fix and additional test 🚀

@joelboim
Copy link
Contributor Author

@rafaela-soares hi:) can you merge it please 🙏

@gabriel-cx gabriel-cx merged commit 298b470 into Checkmarx:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaela-soares rafaela-soares rafaela-soares approved these changes

Assignees
No one assigned
Labels
community Community contribution go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using StartScan with timeout ctx: panic nil pointer dereference
3 participants
@joelboim @rafaela-soares @gabriel-cx