fix(query): align queries #5999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roi-orca
force-pushed
the
align_queries_new
branch
2 times, most recently
from
2d826c4 to
49e4dc4
Compare
rafaela-soares
suggested changes
Nov 14, 2022
| @@ -3,7 +3,7 @@ | |||
| "queryName": "ElastiCache Nodes Not Created Across Multi AZ", | |||
| "severity": "MEDIUM", | |||
| "category": "Availability", | |||
| "descriptionText": "ElastiCache Nodes should have 'AZMode' set to 'cross-az' in in multi nodes cluster", | |||
| "descriptionText": "ElastiCache Nodes should be created across multi az, which means 'AZMode' should be set to 'cross-az' in in multi nodes cluster", | |||
There was a problem hiding this comment.
Can you delete one of the double "in", please? (The same applies for assets/queries/terraform/aws/elasticache_nodes_not_created_across_multi_az and assets/queries/pulumi/aws/elasticache_nodes_not_created_across_multi_az)
Suggested change
| "descriptionText": "ElastiCache Nodes should be created across multi az, which means 'AZMode' should be set to 'cross-az' in in multi nodes cluster", | |
| "descriptionText": "ElastiCache Nodes should be created across multi az, which means 'AZMode' should be set to 'cross-az' in multi nodes cluster", |
| @@ -1,9 +1,9 @@ | |||
| { | |||
| "id": "9fcd0a0a-9b6f-4670-a215-d94e6bf3f184", | |||
| "queryName": "RDS DB Instance With IAM Auth Disabled", | |||
| "queryName": "IAM Database Auth Not Enabled", | |||
There was a problem hiding this comment.
Can you change the query folder name, please?
roi-orca
force-pushed
the
align_queries_new
branch
from
49e4dc4 to
cfbce01
Compare
cxMiguelSilva
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
LGTM
Thank you so much @roi-orca for another amazing contribution!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
align queries cross different platforms
Proposed Changes
align queries cross different platforms
Queries:
COS Node Image Not Used
ElastiCache Nodes Not Created Across Multi AZ
IAM Database Auth Not Enabled
CloudFront Logging Disabled
SQS With SSE Disabled
CloudTrail Log Files Not Encrypted With KMS
Serial Ports Are Enabled For VM Instances
I submit this contribution under the Apache-2.0 license.