Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): update with version regex for unpinned package version in apk add security query #6006

Merged
merged 1 commit into from
Nov 23, 2022
Merged

fix(query): update with version regex for unpinned package version in apk add security query #6006

merged 1 commit into from
Nov 23, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

Closes #6000

Proposed Changes

  • update with version regex in dockerfile.rego to support packages with '+' in name

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added bug Something isn't working query New query feature dockerfile labels Nov 18, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Nov 18, 2022
@cxMiguelSilva cxMiguelSilva mentioned this pull request Nov 18, 2022
Closed
@cxMiguelSilva cxMiguelSilva marked this pull request as ready for review November 18, 2022 13:58
@tspearconquest
Copy link
Contributor

LGTM

gabriel-cx
gabriel-cx approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@gabriel-cx gabriel-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cxMiguelSilva cxMiguelSilva merged commit 31c8659 into master Nov 23, 2022
@cxMiguelSilva cxMiguelSilva deleted the fix_6000 branch November 23, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-cx gabriel-cx gabriel-cx approved these changes

Assignees

@cxMiguelSilva cxMiguelSilva

Labels
bug Something isn't working dockerfile query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive on Unpinned Package Version in Apk Add result when libstdc++ is pinned
3 participants
@cxMiguelSilva @tspearconquest @gabriel-cx