Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): adapt k8s hpa targets invalid object security query #6007

Merged
merged 3 commits into from
Nov 23, 2022
Merged

fix(query): adapt k8s hpa targets invalid object security query #6007

merged 3 commits into from
Nov 23, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

Closes #5990

Proposed Changes

  • change k8s hpa targets invalid object security query in order to only reduce resource fp

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added query New query feature kubernetes Kubernetes query labels Nov 18, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Nov 18, 2022
@cxMiguelSilva cxMiguelSilva mentioned this pull request Nov 18, 2022
Closed
gabriel-cx
gabriel-cx approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@gabriel-cx gabriel-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cxMiguelSilva cxMiguelSilva merged commit f43e7d5 into master Nov 23, 2022
@cxMiguelSilva cxMiguelSilva deleted the fix_5990 branch November 23, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-cx gabriel-cx gabriel-cx approved these changes

Assignees

@cxMiguelSilva cxMiguelSilva

Labels
kubernetes Kubernetes query query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HPA Targets an invalid object query is wrong
2 participants
@cxMiguelSilva @gabriel-cx