Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ssh/rdp access is not restricted #6020

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Fix ssh/rdp access is not restricted #6020

merged 4 commits into from
Dec 6, 2022

Conversation

Tohar-orca
Copy link
Contributor

Closes #

Proposed Changes

  • When GCP firewall rules are defined with no explicit "ports" - all ports are opened by default
  • This change fixes the rules ssh_access_is_not_restricted and rdp_access_is_not_restricted

I submit this contribution under the Apache-2.0 license.

@Tohar-orca Tohar-orca changed the title Fix ssh access is not restricted Fix ssh/rdp access is not restricted Nov 28, 2022
cxMiguelSilva
cxMiguelSilva previously approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tohar-orca,
Thank you so much for your amazing contribution! 🚀
The proposed changes LGTM

cxMiguelSilva
cxMiguelSilva approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cx-joao-reigota
cx-joao-reigota approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@cx-joao-reigota cx-joao-reigota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-joao-reigota cx-joao-reigota merged commit 3477ef1 into Checkmarx:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-joao-reigota cx-joao-reigota cx-joao-reigota approved these changes

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tohar-orca @cx-joao-reigota @cxMiguelSilva