Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bom): add gcp bill of matterials support #6021

Merged
merged 3 commits into from
Nov 30, 2022
Merged

feat(bom): add gcp bill of matterials support #6021

merged 3 commits into from
Nov 30, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva commented Nov 28, 2022 •
edited
Loading

Proposed Changes

  • add BoM support for terraform gcp and Google Deployment Manager
  • add BoM for GCP Persistence disk in Terraform and Google Deployment Manager

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added gcp PR related with GCP Cloud BoM labels Nov 28, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Nov 28, 2022
gabriel-cx
gabriel-cx approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@gabriel-cx gabriel-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cxMiguelSilva cxMiguelSilva merged commit 549268a into master Nov 30, 2022
@cxMiguelSilva cxMiguelSilva deleted the add_gcp_persistence_disk_bom branch November 30, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-cx gabriel-cx gabriel-cx approved these changes

Assignees

@cxMiguelSilva cxMiguelSilva

Labels
BoM gcp PR related with GCP Cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cxMiguelSilva @gabriel-cx