Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): update tf azure aks disk encryption set id undefined security query #6023

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix(query): update tf azure aks disk encryption set id undefined security query #6023

merged 1 commit into from
Nov 30, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

Closes #6022

Proposed Changes

  • add check for os disk type
  • add negative sample
  • update query description

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added bug Something isn't working query New query feature terraform Terraform query azure PR related with Azure Cloud labels Nov 29, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Nov 29, 2022
@cxMiguelSilva cxMiguelSilva mentioned this pull request Nov 29, 2022
Closed
Carus11
Carus11 reviewed Nov 29, 2022
View reviewed changes
assets/queries/terraform/azure/aks_disk_encryption_set_id_undefined/test/negative.tf
name = "default"
node_count = 1
vm_size = "Standard_D2_v2"
os_disk_type = "Ephemeral"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly the method I am using

gabriel-cx
gabriel-cx approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@gabriel-cx gabriel-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cxMiguelSilva cxMiguelSilva merged commit 73dd1f5 into master Nov 30, 2022
@cxMiguelSilva cxMiguelSilva deleted the fix_6022 branch November 30, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carus11 Carus11 Carus11 left review comments

@gabriel-cx gabriel-cx gabriel-cx approved these changes

Assignees

@cxMiguelSilva cxMiguelSilva

Labels
azure PR related with Azure Cloud bug Something isn't working query New query feature terraform Terraform query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add/Update [AKS Disk Encryption Set ID Undefined] query for [Terraform]
3 participants
@cxMiguelSilva @Carus11 @gabriel-cx