Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): fix false positive in sqs with sse disabled for aws cloudformation #6038

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix(query): fix false positive in sqs with sse disabled for aws cloudformation #6038

merged 1 commit into from
Dec 7, 2022

Conversation

cxMiguelSilva
Copy link
Collaborator

Proposed Changes

  • fix false positive in sqs with sse disabled for aws cloudformation

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added bug Something isn't working query New query feature cloudformation CloudFormation query aws PR related with AWS Cloud labels Dec 6, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Dec 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

kics-logo

KICS version: v1.6.4

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

gabriel-cx
gabriel-cx approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@gabriel-cx gabriel-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cx-joao-reigota
cx-joao-reigota approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@cx-joao-reigota cx-joao-reigota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-joao-reigota cx-joao-reigota merged commit 7ed5d0b into master Dec 7, 2022
@cx-joao-reigota cx-joao-reigota deleted the fix_569 branch December 7, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-joao-reigota cx-joao-reigota cx-joao-reigota approved these changes

@gabriel-cx gabriel-cx gabriel-cx approved these changes

Assignees

@cxMiguelSilva cxMiguelSilva

Labels
aws PR related with AWS Cloud bug Something isn't working cloudformation CloudFormation query query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cxMiguelSilva @cx-joao-reigota @gabriel-cx