Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): fix fp in azure instance using basic authentication #6047

Merged
merged 5 commits into from
Jan 3, 2023
Merged

fix(query): fix fp in azure instance using basic authentication #6047

merged 5 commits into from
Jan 3, 2023

Conversation

cxMiguelSilva
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva commented Dec 12, 2022 •
edited
Loading

Closes #5870

Proposed Changes

  • fix fp in azure instance using basic authentication

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added bug Something isn't working query New query feature azure PR related with Azure Cloud arm Azure Resource Manager query labels Dec 12, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Dec 12, 2022
@github-actions
Copy link
Contributor

kics-logo

KICS version: v1.6.5

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

cx-joao-reigota
cx-joao-reigota approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@cx-joao-reigota cx-joao-reigota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-joao-reigota cx-joao-reigota merged commit 611414e into master Jan 3, 2023
@cx-joao-reigota cx-joao-reigota deleted the fix_474 branch January 3, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-joao-reigota cx-joao-reigota cx-joao-reigota approved these changes

Assignees

@cxMiguelSilva cxMiguelSilva

Labels
arm Azure Resource Manager query azure PR related with Azure Cloud bug Something isn't working query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure Instance Using Basic Authentication Security Query Detects False Positive Result
2 participants
@cxMiguelSilva @cx-joao-reigota