Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(arm): add checks for parametes with default values #6053

Merged
merged 6 commits into from
Jan 3, 2023
Merged

feat(arm): add checks for parametes with default values #6053

merged 6 commits into from
Jan 3, 2023

Conversation

cxMiguelSilva
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva commented Dec 15, 2022 •
edited
Loading

Closes #5876

Proposed Changes

  • add checks for parameter definitions

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva cxMiguelSilva added bug Something isn't working query New query feature azure PR related with Azure Cloud arm Azure Resource Manager query labels Dec 15, 2022
@cxMiguelSilva cxMiguelSilva self-assigned this Dec 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2022 •
edited
Loading

kics-logo

KICS version: v1.6.5

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 2

@cxMiguelSilva cxMiguelSilva changed the title fix(qeury): fix actiontrail trail oss bucket is publicly accessible fix(query): fix actiontrail trail oss bucket is publicly accessible Dec 15, 2022
@cxMiguelSilva cxMiguelSilva changed the title fix(query): fix actiontrail trail oss bucket is publicly accessible feat(arm): add checks for parametes with default values Dec 15, 2022
@cxMiguelSilva cxMiguelSilva marked this pull request as ready for review December 15, 2022 17:02
gabriel-cx
gabriel-cx previously approved these changes Jan 3, 2023
View reviewed changes
cx-joao-reigota
cx-joao-reigota previously approved these changes Jan 3, 2023
View reviewed changes
@cx-joao-reigota cx-joao-reigota dismissed stale reviews from gabriel-cx and themself via 3ce4cfd January 3, 2023 13:57
@cx-joao-reigota cx-joao-reigota merged commit f1a971c into master Jan 3, 2023
@cx-joao-reigota cx-joao-reigota deleted the fix_477 branch January 3, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cx-joao-reigota cx-joao-reigota cx-joao-reigota approved these changes

@gabriel-cx gabriel-cx gabriel-cx left review comments

Assignees

@cxMiguelSilva cxMiguelSilva

Labels
arm Azure Resource Manager query azure PR related with Azure Cloud bug Something isn't working query New query feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standard Price Is Not Selected Security Query False Positive
3 participants
@cxMiguelSilva @cx-joao-reigota @gabriel-cx