Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added check for RDS backup_retention_period default #6057

Merged
merged 3 commits into from
Jan 2, 2023
Merged

added check for RDS backup_retention_period default #6057

merged 3 commits into from
Jan 2, 2023

Conversation

cx-joao-reigota
Copy link
Collaborator

I submit this contribution under the Apache-2.0 license.

@cx-joao-reigota cx-joao-reigota added query New query feature terraform Terraform query accuracy Query accuracy (FN and FP) labels Dec 16, 2022
@cx-joao-reigota cx-joao-reigota self-assigned this Dec 16, 2022
@github-actions
Copy link
Contributor

kics-logo

KICS version: v1.6.5

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

cxMiguelSilva
cxMiguelSilva requested changes Dec 19, 2022
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the query.rego file LGTM.
We should remove the is added to common.rego file
And delete the negative3.tf and negative4.tf since they are positive samples now.

cxMiguelSilva
cxMiguelSilva approved these changes Jan 2, 2023
View reviewed changes
Copy link
Collaborator

@cxMiguelSilva cxMiguelSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cxMiguelSilva cxMiguelSilva merged commit 73aa522 into master Jan 2, 2023
@cxMiguelSilva cxMiguelSilva deleted the fix/rds_with_backup_disabled branch January 2, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxMiguelSilva cxMiguelSilva cxMiguelSilva approved these changes

Assignees

@cx-joao-reigota cx-joao-reigota

Labels
accuracy Query accuracy (FN and FP) query New query feature terraform Terraform query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cx-joao-reigota @cxMiguelSilva