-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): add cbs disk without encrypted for tencentcloud #6904
feat(query): add cbs disk without encrypted for tencentcloud #6904
Conversation
Please help review the pr~ |
Already add new cloudProvider : |
assets/queries/terraform/tencentcloud/disk_encryption_disabled/metadata.json
Show resolved
Hide resolved
d62ee6c
to
53af687
Compare
53af687
to
48b09e3
Compare
Why does the e2e-debian-tests fail? I can’t seem to see the detailed error message. |
Hi @hellertang , In this case we just need to rerun the test. The issue is not related to your PR's changes, do not worry :D |
Thanks. We sincerely hope that KICS can support the inspection of Tencent Cloud's Terraform resources. I aspire for this PR to be integrated, as a testament to the feasibility of this path. In doing so, we can strive to contribute more inspection rules pertinent to the Tencent Cloud Provider. |
Nice to know! Thank you again for this amazing contribution! Kindly be aware that, since this is a new cloud provider support (tencentcloud), after this PR is merged, in order to run this new queries you need to use the KICS flag |
@hellertang kindly add a line for tencentcloud here as well. So the unit tests can run against tencentcloud queries. |
Got it, thanks. Already fix just now. |
thanks @hellertang ! |
Thanks @gabriel-cx . Already fix it just now. I have discerned that if 'experimental' is set to true, 'Remediation' cannot be established in 'query.go', as this would result in the unit test not being able to execute successfully. So I remove it. |
Thank you @hellertang ! |
Hi @hellertang , I'm happy to let you know that your tencentcloud queries are now part of the KICS 'official queries'! Thank you again for all your help on this! |
Proposed Changes
I submit this contribution under the Apache-2.0 license.