Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): add cbs disk without encrypted for tencentcloud #6904

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

hellertang
Copy link
Contributor

Proposed Changes

  • CBS Disk Without Encrypted for TencentCloud

I submit this contribution under the Apache-2.0 license.

@github-actions github-actions bot added community Community contribution feature request Community: new feature request query New query feature labels Feb 23, 2024
@hellertang hellertang changed the title feat(query): Added CBS Disk Without Encrypted for TencentCloud feat(query): add cbs disk without encrypted for tencentcloud Feb 23, 2024
@hellertang
Copy link
Contributor Author

Please help review the pr~

@hellertang
Copy link
Contributor Author

Already add new cloudProvider : tencentcloud in .github/scripts/queries-validator/metadata-schema.json. Please check and run again. Thanks.

@hellertang hellertang force-pushed the feature/cbs_without_encrypt branch from d62ee6c to 53af687 Compare February 27, 2024 01:33
@hellertang hellertang force-pushed the feature/cbs_without_encrypt branch from 53af687 to 48b09e3 Compare February 27, 2024 01:34
@hellertang
Copy link
Contributor Author

Why does the e2e-debian-tests fail? I can’t seem to see the detailed error message.
Please tell me how to fix.
Thanks.

@gabriel-cx
Copy link
Contributor

Why does the e2e-debian-tests fail? I can’t seem to see the detailed error message. Please tell me how to fix. Thanks.

Hi @hellertang ,

In this case we just need to rerun the test. The issue is not related to your PR's changes, do not worry :D

@hellertang
Copy link
Contributor Author

Why does the e2e-debian-tests fail? I can’t seem to see the detailed error message. Please tell me how to fix. Thanks.

Hi @hellertang ,

In this case we just need to rerun the test. The issue is not related to your PR's changes, do not worry :D

Thanks. We sincerely hope that KICS can support the inspection of Tencent Cloud's Terraform resources. I aspire for this PR to be integrated, as a testament to the feasibility of this path. In doing so, we can strive to contribute more inspection rules pertinent to the Tencent Cloud Provider.

@gabriel-cx
Copy link
Contributor

gabriel-cx commented Feb 27, 2024

Why does the e2e-debian-tests fail? I can’t seem to see the detailed error message. Please tell me how to fix. Thanks.

Hi @hellertang ,
In this case we just need to rerun the test. The issue is not related to your PR's changes, do not worry :D

Thanks. We sincerely hope that KICS can support the inspection of Tencent Cloud's Terraform resources. I aspire for this PR to be integrated, as a testament to the feasibility of this path. In doing so, we can strive to contribute more inspection rules pertinent to the Tencent Cloud Provider.

Nice to know! Thank you again for this amazing contribution!

Kindly be aware that, since this is a new cloud provider support (tencentcloud), after this PR is merged, in order to run this new queries you need to use the KICS flag --experimental-queries.
After merging this PR, we will update our documentation as well, so we can mention Tencent Cloud as a new support, under our Beta Features section.

@gabriel-cx
Copy link
Contributor

@hellertang kindly add a line for tencentcloud here as well. So the unit tests can run against tencentcloud queries.

@hellertang
Copy link
Contributor Author

@hellertang kindly add a line for tencentcloud here as well. So the unit tests can run against tencentcloud queries.

Got it, thanks. Already fix just now.

@gabriel-cx
Copy link
Contributor

thanks @hellertang !

kindly be aware of this failing unit test:
image

@hellertang
Copy link
Contributor Author

thanks @hellertang !

kindly be aware of this failing unit test: image

Thanks @gabriel-cx . Already fix it just now.

I have discerned that if 'experimental' is set to true, 'Remediation' cannot be established in 'query.go', as this would result in the unit test not being able to execute successfully. So I remove it.

@gabriel-cx gabriel-cx merged commit e09d3d2 into Checkmarx:master Feb 28, 2024
22 checks passed
@gabriel-cx
Copy link
Contributor

Thank you @hellertang !
This week we will release a new KICS version (v1.7.13) and Tencent Cloud support will be part of it!

@gabriel-cx
Copy link
Contributor

Hi @hellertang ,

I'm happy to let you know that your tencentcloud queries are now part of the KICS 'official queries'!
This means, tencentcloud queries will run by default when KICS detects terraform files.
This functionality will start to be available in the next KICS version (v2.1.0).

Thank you again for all your help on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution feature request Community: new feature request query New query feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants