(0.4.0) Integrate sea ice in the flux computation #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simone-silvestri
changed the title
|
I cannot approve this PR since I am the author, if someone approves it, I can merge when the tests pass. |
glwagner
approved these changes
Feb 13, 2025
glwagner
reviewed
Feb 13, 2025
| Qio = sea_ice_ocean_fluxes.heat[i, j, 1] | ||
| Jˢio = sea_ice_ocean_fluxes.salt[i, j, 1] | ||
| Qio = get_ice_heat_flux(i, j, 1, grid, sea_ice_ocean_fluxes)[i, j, 1] | ||
| Jˢio = get_ice_salt_flux(i, j, 1, grid, sea_ice_ocean_fluxes)[i, j, 1] |
There was a problem hiding this comment.
just remember to give some weight to the value of refactoring if that would help clean things up
There was a problem hiding this comment.
yeah I have reordered a bit, I like it better now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a tentative implementation for atmosphere-sea-ice computations to be able to integrate sea-ice in the
OceanSeaIceModel.The objective is trying to reuse as much as possible of the infrastructure in place for atmosphere - ocean fluxes
I think everything is roughly in place, we just need to change the surface properties and implement a way to limit the surface temperature to the melting temperature in the surface temperature computation