Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up treatment of floating point precision and use Oceananigans.defaults.FloatType #346

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

glwagner
Copy link
Member

This makes ClimaOcean obey the default set by Oceananigans, and also converts the grids for bathymetry and ECCO to Float32, which I think is correct and might save some memory.

@glwagner glwagner merged commit 745dbb0 into main Feb 24, 2025
18 checks passed
@glwagner glwagner deleted the glw/use-float-default branch February 24, 2025 22:33
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (a27e5f1) to head (1795dcb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...eModels/InterfaceComputations/roughness_lengths.jl 0.00% 5 Missing ⚠️
src/OceanSeaIceModels/PrescribedAtmospheres.jl 0.00% 4 Missing ⚠️
src/Bathymetry.jl 0.00% 2 Missing ⚠️
...Computations/similarity_theory_turbulent_fluxes.jl 0.00% 2 Missing ⚠️
src/DataWrangling/ECCO/ECCO.jl 0.00% 1 Missing ⚠️
...Computations/coefficient_based_turbulent_fluxes.jl 0.00% 1 Missing ⚠️
...ceModels/InterfaceComputations/interface_states.jl 0.00% 1 Missing ⚠️
...eanSeaIceModels/InterfaceComputations/radiation.jl 0.00% 1 Missing ⚠️
...ceModels/InterfaceComputations/tabulated_albedo.jl 0.00% 1 Missing ⚠️
...SeaIceModels/freezing_limited_ocean_temperature.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #346   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         36      36           
  Lines       2291    2291           
=====================================
  Misses      2291    2291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants