Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize flux solver stop criteria to include FixedIterations #350

Merged
merged 6 commits into from
Feb 24, 2025

Conversation

glwagner
Copy link
Member

This PR adds the feature to fix the number of iterations used in the flux solver. cc @wsmoses

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (10d72f5) to head (e91c028).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...s/InterfaceComputations/compute_interface_state.jl 0.00% 45 Missing ⚠️
...Computations/coefficient_based_turbulent_fluxes.jl 0.00% 3 Missing ⚠️
...Computations/similarity_theory_turbulent_fluxes.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #350   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         35      36    +1     
  Lines       2284    2291    +7     
=====================================
- Misses      2284    2291    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simone-silvestri
Copy link
Collaborator

wouldn't this be achieved by tolerance=0, maxiter=fixed_iteration_number?

@simone-silvestri
Copy link
Collaborator

Is this required for an ulterior motive?

@glwagner glwagner merged commit a27e5f1 into main Feb 24, 2025
20 checks passed
@glwagner glwagner deleted the glw/fixed-iterations branch February 24, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants