Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist FractionalIndices with two separate arrays for i, j #371

Merged
merged 23 commits into from
Mar 6, 2025

Conversation

simone-silvestri
Copy link
Collaborator

@simone-silvestri simone-silvestri commented Mar 4, 2025

The fact that GPU tests do not run is starting to have quite a price on the development process.

close #370

@glwagner
Copy link
Member

glwagner commented Mar 4, 2025

The fact that GPU tests do not run is starting to have quite a price on the development process.

close #370

I don't agree that its "starting" to have a price. From the very moment the tests stop working, way pay the price. It doesn't take any time.

@glwagner glwagner changed the title One missing allowscalar in the StateExchanger Persist FractionalIndices with two separate arrays for i, j Mar 5, 2025
@simone-silvestri simone-silvestri mentioned this pull request Mar 5, 2025
@navidcy navidcy added the tests Helpful for getting a good night's sleep label Mar 5, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (fa37f3c) to head (9c0cc89).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rfaceComputations/interpolate_atmospheric_state.jl 0.00% 20 Missing ⚠️
...dels/InterfaceComputations/component_interfaces.jl 0.00% 16 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #371   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         38      38           
  Lines       2354    2368   +14     
=====================================
- Misses      2354    2368   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glwagner glwagner merged commit 7e5ece5 into main Mar 6, 2025
20 checks passed
@glwagner glwagner deleted the ss/fix-gpu-bug branch March 6, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Helpful for getting a good night's sleep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is an issue with StateExchanger on GPUs
3 participants