Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expansion Hunter module, #442 #443

Merged

Conversation

jemten
Copy link
Collaborator

@jemten jemten commented Mar 23, 2018

No description provided.

Copy link
Collaborator

@henrikstranneheim henrikstranneheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

## : $min_anchor_mapq => Min MAPQ of an in-repeat read anchor
## : $min_baseq => Min base quality of a high confidece base call
## : $min_score => Min weigheted matching score
## : $read_depth => Expansion Hunter will not calciulate read depth if set
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calciulate -> calculate

unix_write_to_file(
{
FILEHANDLE => $FILEHANDLE,
commands_ref => \@commands,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order AB


analysis_expansionhunter(
{
parameter_href => $parameter_href,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order AB

$log->info(q{[ExpansionHunter]});

my $cnvnator_program_name = q{expansionhunter};

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add loop label

@jemten
Copy link
Collaborator Author

jemten commented Mar 23, 2018

Ooos, the pipeline recipe wasn't supposed to be a part of this pull request. (To eager with git add -u). I will change according to your suggestions and possibly update it again when it is time for the analysis recipe.

@henrikstranneheim
Copy link
Collaborator

I wondered about that. Good plan!

@henrikstranneheim
Copy link
Collaborator

Alright so I will not merge this until you say so!

@jemten
Copy link
Collaborator Author

jemten commented Mar 23, 2018

I think it is OK to merge it now. Since $active_parameter_href->{pexpansionhunter} isn't defined anywhere yet it shouldn't interfere with anyone else's work. Would be nice to get this part out of the way.

@henrikstranneheim
Copy link
Collaborator

👍

@henrikstranneheim henrikstranneheim merged commit 2e9f648 into Clinical-Genomics:develop Mar 23, 2018
@jemten jemten deleted the feature/exphun_module branch March 23, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants