-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe for Expansaion Hunter, fixes #442 #463
Recipe for Expansaion Hunter, fixes #442 #463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good!
- pexpansionhunter | ||
data_type: SCALAR | ||
exists_check: directory | ||
mandatory: no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not mandatory to supply "expansionhunter_repeat_specs_dir" to run with expansionhunter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to have the repeat spec files for running the program. I'm trying to set the repeat spec directory to the one supplied with the program if you haven't supplied the path in the config
|
||
sub analysis_expansionhunter { | ||
|
||
## Function : Call expansions of STR using Expansion Hunter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
STR -> Short tandem repeats (STR)
|
||
my ($arg_href) = @_; | ||
|
||
## Default(s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move block under ## Flatten argument(s) to comply with latest template
## Creates program directories (info & programData & programScript), program script filenames and writes sbatch header | ||
my ( $file_path, $program_info_path ) = setup_script( | ||
{ | ||
active_parameter_href => $active_parameter_href, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Order AB
} | ||
); | ||
|
||
#Used downstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#U -> # U
{ | ||
parameter_href => $parameter_href, | ||
suffix_key => q{variant_file_suffix}, | ||
job_id_chain => $job_id_chain, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Order AB
); | ||
say {$FILEHANDLE} q{wait} . $NEWLINE; | ||
|
||
## Rename the bam file index file so that Expansion Hunter can find it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐️
); | ||
} | ||
|
||
if ( not -d $repeat_specs_dir_path ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to late since MIP will have launched all programs upstream already. This must be checked before launching to SLURM. We should always check everything before that and fail if required. Would be nice to add to: set_custom_default_to_active_parameter in MAIN/Analyse.pm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True! Will move the check
{ | ||
FILEHANDLE => $FILEHANDLE, | ||
infile_path => $file_path_prefix . $infile_suffix, | ||
json_outfile_path => $outfile_path_prefix . q{.json}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$DOT . q{json}
return; | ||
} | ||
|
||
sub _get_default_repeat_specs_dir_path { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to MAIN/Analyse.pm set_custom_default_to_active_parameter part for rare_disease (only)
Awesome! |
No description provided.