Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially fix #5310 - allow loading of mixed cases with some fully WTS sample individuals #5327

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

dnil
Copy link
Collaborator

@dnil dnil commented Mar 14, 2025

This PR adds a functionality or fixes a bug.

Testing on cg-vm1 server (Clinical Genomics Stockholm)

Prepare for testing

  1. Make sure the PR is pushed and available on Docker Hub
  2. Fist book your testing time using the Pax software available at https://pax.scilifelab.se/. The resource you are going to call dibs on is scout-stage and the server is cg-vm1.
  3. ssh <USER.NAME>@cg-vm1.scilifelab.se
  4. sudo -iu hiseq.clinical
  5. ssh localhost
  6. (optional) Find out which scout branch is currently deployed on cg-vm1: podman ps
  7. Stop the service with current deployed branch: systemctl --user stop scout.target
  8. Start the scout service with the branch to test: systemctl --user start scout@<this_branch>
  9. Make sure the branch is deployed: systemctl --user status scout.target
  10. After testing is done, repeat procedure at https://pax.scilifelab.se/, which will release the allocated resource (scout-stage) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm)

Prepare for testing

  1. ssh <USER.NAME>@hasta.scilifelab.se
  2. Book your testing time using the Pax software. us; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.
  3. (optional) Find out which scout branch is currently deployed on cg-vm1: conda activate S_scout; pip freeze | grep scout-browser
  4. Deploy the branch to test: bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
  5. Make sure the branch is deployed: us; scout --version
  6. After testing is done, repeat the paxa procedure, which will release the allocated resource (scout-stage) to be used for testing by other users.

How to test:

  1. Add a pure (fake) wts individual to a case, e.g.
diff --git a/scout/demo/643594.config.yaml b/scout/demo/643594.config.yaml
index a3ddcb2b3..4524166b4 100644
--- a/scout/demo/643594.config.yaml
+++ b/scout/demo/643594.config.yaml
@@ -88,6 +88,20 @@ samples:
     splice_junctions_bed: scout/demo/ACC5963A1_lanes_1234_star_sorted_sj_filtered_sorted.bed.gz
     d4_file: scout/demo/ADM1059A3.d4

+  - analysis_type: wts
+    sample_id: ADM1059A4
+    father: '0'
+    mother: '0'
+    sample_name: NA12879
+    phenotype: unaffected
+    sex: female
+    expected_coverage: 30
+    tissue_type: blood
+    omics_sample_id: RNA1059A4
+    rna_coverage_bigwig: scout/demo/ACC5963A1_lanes_1234_star_sorted_sj_filtered.bigWig
+    splice_junctions_bed: scout/demo/ACC5963A1_lanes_1234_star_sorted_sj_filtered_sorted.bed.gz
  1. attempt loading
  2. see it fail on main, work on PR

Screenshot 2025-03-14 at 13 41 04

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by
  • tests executed by

@@ -88,6 +88,20 @@ samples:
splice_junctions_bed: scout/demo/ACC5963A1_lanes_1234_star_sorted_sj_filtered_sorted.bed.gz
d4_file: scout/demo/ADM1059A3.d4

- analysis_type: wts
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to keep this. Or could keep it as a separate case I guess, but l'm going to keep it a little bit to see if we can get the tests to shake out some more issue (or if it just takes too much effort to clear up the test assumptions).

"mate_id": coordinates["mate_id"],
"position": coordinates["position"],
"sub_category": coordinates["sub_category"],
"samples": get_samples(variant, individual_positions, case, category),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change really: we pass on the category given to this function for checking that the samples are relevant to the variant type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading more RNA tracks to a case for more individuals than there are DNA samples already
1 participant